refactor: replace moment with dayjs #1856

hyperz111 · 2026-02-02T08:28:34Z

moment is unmaintained, so i replace it with dayjs.

gemini-code-assist · 2026-02-02T08:29:06Z

Summary of Changes

Hello @hyperz111, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project's date handling by replacing the moment.js library with dayjs. The primary motivation is to move away from an unmaintained dependency to a more actively developed and performant alternative. This change involves updating package dependencies and migrating existing date manipulation code to use the dayjs API, ensuring continued functionality with improved maintainability.

Highlights

Dependency Update: Replaced the unmaintained moment.js library with dayjs for date manipulation. This change addresses the maintenance status of moment.js and introduces a more modern, lightweight alternative.
Package Management: Updated package.json and package-lock.json to reflect the removal of moment and the addition of dayjs as a dependency.
Code Migration: Migrated date formatting logic in src/pages/plugin/plugin.view.js from moment to dayjs, including importing necessary dayjs plugins (relativeTime, updateLocale) and adapting API calls.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

greptile-apps · 2026-02-02T08:29:59Z

Greptile Overview

Greptile Summary

This PR replaces the unmaintained moment dependency with dayjs, updating package.json/package-lock.json and switching the plugin details view to use Day.js + relativeTime/updateLocale.

The main behavioral risk is in src/pages/plugin/plugin.view.js, where the new Day.js calls can change the displayed “updated” text and its timezone semantics compared to the previous moment.utc(...).fromNow() behavior.

Confidence Score: 3/5

This PR is likely safe to merge, but includes a user-visible behavior change in relative time formatting/timezone handling that should be verified.
Dependency swap is straightforward, but fromNow(true) and dropping utc semantics can change displayed timestamps; global locale mutation inside a formatter may also have app-wide side effects.
src/pages/plugin/plugin.view.js

Important Files Changed

Filename	Overview
package.json	Swaps moment dependency for dayjs in dependencies.
package-lock.json	Updates lockfile to add dayjs@1.11.19 and remove moment@2.30.1.
src/pages/plugin/plugin.view.js	Replaces moment usage with dayjs relativeTime/updateLocale plugins; potential behavior changes in relative time formatting.

Sequence Diagram

sequenceDiagram
  participant UI as Plugin view (plugin.view.js)
  participant Dayjs as dayjs + plugins

  UI->>Dayjs: extend(relativeTime)
  UI->>Dayjs: extend(updateLocale)

  UI->>UI: render Plugin page
  UI->>UI: formatUpdatedDate(packageUpdatedAt)
  UI->>Dayjs: updateLocale("en", relativeTime overrides)
  UI->>Dayjs: dayjs(dateString)
  Dayjs-->>UI: Dayjs instance
  UI->>Dayjs: isValid()
  Dayjs-->>UI: boolean
  UI->>Dayjs: fromNow(true)
  Dayjs-->>UI: relative string
  UI-->>UI: display "(updatedText)" in Version component

greptile-apps

_{3 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

src/pages/plugin/plugin.view.js

greptile-apps · 2026-02-02T08:30:08Z

Additional Comments (1)

src/pages/plugin/plugin.view.js
[P1] fromNow(true) drops the “ago/in …” suffix, changing UI text

In formatUpdatedDate, moment.utc(dateString).fromNow() previously returned strings including the suffix (e.g., "5m ago"). With Day.js you’re currently doing updateTime.fromNow(true), which returns only the distance (e.g., "5m") and will never append past/future strings (so the past: "%s ago" config won’t apply). This changes the displayed packageUpdatedAt text.

Also, moment.utc(dateString) preserved UTC semantics; dayjs(dateString) will parse in local time unless the input includes a timezone offset. If package_updated_at is UTC and doesn’t include an offset, this can skew the relative time.

A minimal fix is to use fromNow() (no arg) and, if UTC is required, dayjs.utc(dateString) with the utc plugin.

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/pages/plugin/plugin.view.js
Line: 52:80

Comment:
[P1] `fromNow(true)` drops the “ago/in …” suffix, changing UI text

In `formatUpdatedDate`, `moment.utc(dateString).fromNow()` previously returned strings including the suffix (e.g., `"5m ago"`). With Day.js you’re currently doing `updateTime.fromNow(true)`, which returns *only* the distance (e.g., `"5m"`) and will never append `past`/`future` strings (so the `past: "%s ago"` config won’t apply). This changes the displayed `packageUpdatedAt` text.

Also, `moment.utc(dateString)` preserved UTC semantics; `dayjs(dateString)` will parse in local time unless the input includes a timezone offset. If `package_updated_at` is UTC and doesn’t include an offset, this can skew the relative time.

A minimal fix is to use `fromNow()` (no arg) and, if UTC is required, `dayjs.utc(dateString)` with the `utc` plugin.


How can I resolve this? If you propose a fix, please make it concise.

gemini-code-assist

Code Review

This pull request successfully replaces the unmaintained moment library with dayjs. The dependency changes in package.json and package-lock.json are correct. However, I've identified a critical issue in src/pages/plugin/plugin.view.js where replacing moment.utc() with dayjs() could lead to incorrect date parsing due to timezone differences. I've also pointed out an opportunity to improve performance and fix a minor display bug by moving the dayjs locale configuration out of a frequently called function. Overall, a good refactoring with a couple of important adjustments needed.

src/pages/plugin/plugin.view.js

UnschooledGamer · 2026-02-02T08:33:28Z

While Moment.js is unmaintained it's API is pretty much good considerably. The Moment.js is a Pretty Much Done on its base Feature set. Also, Moment.js explained this better in their docs here -> https://momentjs.com/docs/#/-project-status/

hyperz111 · 2026-02-02T08:41:58Z

I get the moment replacement from this

bajrangCoder · 2026-02-02T15:20:37Z

I don't think there is need for this change.

hyperz111 · 2026-02-02T23:01:04Z

I don't think there is need for this change.

I get this build size difference.

Before:

$ du -sh www/build
5.9M    www/build

After:

$ du -sh www/build
5.6M    www/build

UnschooledGamer · 2026-02-03T15:20:49Z

I don't think there is need for this change.

@bajrangCoder, I think you should read https://momentjs.com/docs/#/-project-status/ before making a decision, also considering the package of moment.js (~4 mb) and dayjs being <1 mb

hyperz111 and others added 16 commits August 18, 2025 10:33

chore: update id-id.json

73840ac

Merge branch 'Acode-Foundation:main' into main

f8e6949

Merge branch 'Acode-Foundation:main' into main

3c56da5

Merge branch 'Acode-Foundation:main' into main

4954d48

Merge branch 'Acode-Foundation:main' into main

1adb8a1

Merge branch 'Acode-Foundation:main' into main

b635fe8

fix(i18n): fix typo in ./src/lang/id-id.json

0c4fe92

Merge branch 'Acode-Foundation:main' into main

8420daf

chore(i18n): update id-id.json with new strings

c274981

Merge branch 'Acode-Foundation:main' into main

a843912

Merge branch 'Acode-Foundation:main' into main

f0b550e

Merge branch 'Acode-Foundation:main' into main

7175ef4

Merge branch 'Acode-Foundation:main' into main

0b4e8ac

Merge branch 'Acode-Foundation:main' into main

70a4eb9

Merge branch 'Acode-Foundation:main' into main

455b367

refactor: replace moment with dayjs

378279e

greptile-apps bot reviewed Feb 2, 2026

View reviewed changes

src/pages/plugin/plugin.view.js Outdated Show resolved Hide resolved

gemini-code-assist bot reviewed Feb 2, 2026

View reviewed changes

src/pages/plugin/plugin.view.js Outdated Show resolved Hide resolved

UnschooledGamer requested a review from bajrangCoder February 2, 2026 08:40

hyperz111 added 2 commits February 2, 2026 15:43

chore: use utc plugin

fad8730

chore: move dayjs config to top

2ee7f49

UnschooledGamer added the community label Feb 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: replace moment with dayjs #1856

refactor: replace moment with dayjs #1856

hyperz111 commented Feb 2, 2026

Uh oh!

gemini-code-assist bot commented Feb 2, 2026

Uh oh!

greptile-apps bot commented Feb 2, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

greptile-apps bot commented Feb 2, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

UnschooledGamer commented Feb 2, 2026

Uh oh!

hyperz111 commented Feb 2, 2026 •

edited

Loading

Uh oh!

bajrangCoder commented Feb 2, 2026

Uh oh!

hyperz111 commented Feb 2, 2026 •

edited

Loading

Uh oh!

UnschooledGamer commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor: replace moment with dayjs #1856

Are you sure you want to change the base?

refactor: replace moment with dayjs #1856

Conversation

hyperz111 commented Feb 2, 2026

Uh oh!

gemini-code-assist bot commented Feb 2, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

greptile-apps bot commented Feb 2, 2026

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot commented Feb 2, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

UnschooledGamer commented Feb 2, 2026

Uh oh!

hyperz111 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bajrangCoder commented Feb 2, 2026

Uh oh!

hyperz111 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UnschooledGamer commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hyperz111 commented Feb 2, 2026 •

edited

Loading

hyperz111 commented Feb 2, 2026 •

edited

Loading